From: Sergio Paracuellos Date: Fri, 25 May 2018 16:54:48 +0000 (+0200) Subject: staging: mt7621-gpio: use module_platform_driver() instead subsys initcall X-Git-Tag: v4.18-rc1~83^2~23 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ba64745694e20b4aa6738f17c1583c7f4832daf5;p=thirdparty%2Fkernel%2Flinux.git staging: mt7621-gpio: use module_platform_driver() instead subsys initcall The driver's init function don't do anything besides registering the platform driver, and the exit function which is not included in the driver should only do driver unregister. Because of this module_platform_driver() macro could just be used instead of having separate functions. Currently the macro is not being used because the driver is initialized at subsys init call level but this isn't necessary since platform devices are defined in the DT as dependencies so there's no need for init calls order. Signed-off-by: Sergio Paracuellos Reviewed-by: NeilBrown Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/mt7621-gpio/gpio-mt7621.c b/drivers/staging/mt7621-gpio/gpio-mt7621.c index 64169367861cc..d41cc3ed437c7 100644 --- a/drivers/staging/mt7621-gpio/gpio-mt7621.c +++ b/drivers/staging/mt7621-gpio/gpio-mt7621.c @@ -379,10 +379,4 @@ static struct platform_driver mediatek_gpio_driver = { }, }; -static int __init -mediatek_gpio_init(void) -{ - return platform_driver_register(&mediatek_gpio_driver); -} - -subsys_initcall(mediatek_gpio_init); +module_platform_driver(mediatek_gpio_driver);