From: Tom de Vries <tdevries@suse.de>
Date: Mon, 19 Jun 2023 09:15:56 +0000 (+0200)
Subject: [gdb/tui] Simplify tui_update_variables
X-Git-Tag: binutils-2_41~216
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ba769bb0e6fdf5b4c55577b068b93adf2f6d1333;p=thirdparty%2Fbinutils-gdb.git

[gdb/tui] Simplify tui_update_variables

Simplify tui_update_variables by using template function
assign_return_if_changed.

Tested on x86_64-linux.
---

diff --git a/gdb/tui/tui-win.c b/gdb/tui/tui-win.c
index 7bceebb4525..7d58a2db251 100644
--- a/gdb/tui/tui-win.c
+++ b/gdb/tui/tui-win.c
@@ -284,28 +284,20 @@ tui_update_variables ()
   struct tui_translate *entry;
 
   entry = translate (tui_border_mode, tui_border_mode_translate);
-  if (tui_border_attrs != entry->value)
-    {
-      tui_border_attrs = entry->value;
-      need_redraw = true;
-    }
+  need_redraw
+    |= assign_return_if_changed<int> (tui_border_attrs, entry->value);
+
   entry = translate (tui_active_border_mode, tui_border_mode_translate);
-  if (tui_active_border_attrs != entry->value)
-    {
-      tui_active_border_attrs = entry->value;
-      need_redraw = true;
-    }
+  need_redraw
+    |= assign_return_if_changed<int> (tui_active_border_attrs, entry->value);
 
   /* If one corner changes, all characters are changed.
      Only check the first one.  The ACS characters are determined at
      run time by curses terminal management.  */
   entry = translate (tui_border_kind, tui_border_kind_translate_lrcorner);
   int val = (entry->value < 0) ? ACS_LRCORNER : entry->value;
-  if (tui_border_lrcorner != (chtype) val)
-    {
-      tui_border_lrcorner = val;
-      need_redraw = true;
-    }
+  need_redraw |= assign_return_if_changed<chtype> (tui_border_lrcorner, val);
+
   entry = translate (tui_border_kind, tui_border_kind_translate_llcorner);
   tui_border_llcorner = (entry->value < 0) ? ACS_LLCORNER : entry->value;