From: Ivan Vecera <ivecera@redhat.com>
Date: Fri, 19 Jan 2018 08:18:54 +0000 (+0100)
Subject: kernfs: fix regression in kernfs_fop_write caused by wrong type
X-Git-Tag: v4.16-rc1~13^2~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ba87977a49913129962af8ac35b0e13e0fa4382d;p=thirdparty%2Fkernel%2Flinux.git

kernfs: fix regression in kernfs_fop_write caused by wrong type

Commit b7ce40cff0b9 ("kernfs: cache atomic_write_len in
kernfs_open_file") changes type of local variable 'len' from ssize_t
to size_t. This change caused that the *ppos value is updated also
when the previous write callback failed.

Mentioned snippet:
...
len = ops->write(...); <- return value can be negative
...
if (len > 0)           <- true here in this case
        *ppos += len;
...

Fixes: b7ce40cff0b9 ("kernfs: cache atomic_write_len in kernfs_open_file")
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---

diff --git a/fs/kernfs/file.c b/fs/kernfs/file.c
index 9698e51656b10..d8f49c412f508 100644
--- a/fs/kernfs/file.c
+++ b/fs/kernfs/file.c
@@ -275,7 +275,7 @@ static ssize_t kernfs_fop_write(struct file *file, const char __user *user_buf,
 {
 	struct kernfs_open_file *of = kernfs_of(file);
 	const struct kernfs_ops *ops;
-	size_t len;
+	ssize_t len;
 	char *buf;
 
 	if (of->atomic_write_len) {