From: Otto Moerbeek Date: Tue, 5 Nov 2024 13:57:33 +0000 (+0100) Subject: Apply suggestions from code review X-Git-Tag: rec-5.2.0-alpha1~7^2~1 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ba97322e4a517cb1d45cac3c1523a27286d49dfa;p=thirdparty%2Fpdns.git Apply suggestions from code review Co-authored-by: Kevin P. Fleming --- diff --git a/pdns/recursordist/rec-xfr.hh b/pdns/recursordist/rec-xfr.hh index b6910610d2..96ce86d3ac 100644 --- a/pdns/recursordist/rec-xfr.hh +++ b/pdns/recursordist/rec-xfr.hh @@ -38,7 +38,7 @@ class DNSName; class SOARecordContent; struct FWCatz; -// Please make sure that the struct below only contains value types since they are used as parameters in a thread ct +// All members of this struct must be copyable, as they are used as parameters in a thread constructor struct ZoneXFRParams { std::string name; @@ -103,7 +103,7 @@ struct FWCatz class ZoneXFR { public: - // A struct that holds the condition var and related stuff to allow notifies to be sent to the tread owning + // A struct that holds the condition var and related stuff to allow notifies to be sent to the thread owning // the struct. struct ZoneWaiter { diff --git a/pdns/recursordist/settings/docs-new-preamble-in.rst b/pdns/recursordist/settings/docs-new-preamble-in.rst index 1861501863..5d677c4eb5 100644 --- a/pdns/recursordist/settings/docs-new-preamble-in.rst +++ b/pdns/recursordist/settings/docs-new-preamble-in.rst @@ -492,7 +492,7 @@ As of version 5.2.0, a forwarding catalog zone entry is defined as: localAddress: IP address, default not set axfrTimeout: number, default 20 groups: - - name: + - name: optional group name forwarders: [] Sequence of SocketAddress recurse: bool, default false notify: bool, default false