From: Peter Maydell <peter.maydell@linaro.org>
Date: Sat, 24 Dec 2011 23:37:24 +0000 (+0000)
Subject: gdbstub: Fix fd leak in gdbserver_open() error path
X-Git-Tag: v1.1-rc0~641^2~3
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=bb16172c52ac18742f3df156912c169904e92147;p=thirdparty%2Fqemu.git

gdbstub: Fix fd leak in gdbserver_open() error path

Fix a leak of a file descriptor in error exit paths in
gdbserver_open().

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---

diff --git a/gdbstub.c b/gdbstub.c
index a5806ef6c49..7d470b608ea 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -2762,11 +2762,13 @@ static int gdbserver_open(int port)
     ret = bind(fd, (struct sockaddr *)&sockaddr, sizeof(sockaddr));
     if (ret < 0) {
         perror("bind");
+        close(fd);
         return -1;
     }
     ret = listen(fd, 0);
     if (ret < 0) {
         perror("listen");
+        close(fd);
         return -1;
     }
     return fd;