From: Philippe Mathieu-Daudé <philmd@redhat.com>
Date: Mon, 24 Feb 2020 18:55:35 +0000 (+0100)
Subject: scripts/cocci: Patch to remove unnecessary memory_region_set_readonly()
X-Git-Tag: v5.0.0-rc0~28^2~10
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=bb2f4e8d77c4b39ffc04614e0bbd71b3b3c3b340;p=thirdparty%2Fqemu.git

scripts/cocci: Patch to remove unnecessary memory_region_set_readonly()

Add a semantic patch to remove memory_region_set_readonly() calls
on ROM memory regions.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---

diff --git a/scripts/coccinelle/memory-region-housekeeping.cocci b/scripts/coccinelle/memory-region-housekeeping.cocci
index 9cdde71bb1e..5e6b31d8ba2 100644
--- a/scripts/coccinelle/memory-region-housekeeping.cocci
+++ b/scripts/coccinelle/memory-region-housekeeping.cocci
@@ -48,6 +48,21 @@ p << possible_memory_region_init_rom.p;
 cocci.print_main("potential use of memory_region_init_rom*() in ", p)
 
 
+// Do not call memory_region_set_readonly() on ROM alias
+@@
+expression ROM, E1, E2, E3, E4;
+expression ALIAS, E5, E6, E7, E8;
+@@
+(
+  memory_region_init_rom(ROM, E1, E2, E3, E4);
+|
+  memory_region_init_rom_nomigrate(ROM, E1, E2, E3, E4);
+)
+  ...
+   memory_region_init_alias(ALIAS, E5, E6, ROM, E7, E8);
+-  memory_region_set_readonly(ALIAS, true);
+
+
 // Replace by-hand memory_region_init_ram_nomigrate/vmstate_register_ram
 // code sequences with use of the new memory_region_init_ram function.
 // Similarly for the _rom and _rom_device functions.