From: Christopher Faulet <cfaulet@haproxy.com>
Date: Thu, 21 Apr 2022 08:28:30 +0000 (+0200)
Subject: BUG/MINOR: backend: Don't allow to change backend applet
X-Git-Tag: v2.6-dev7~15
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=bb5b62ee5c0ce5077559c6f42ad1fb4451bf95de;p=thirdparty%2Fhaproxy.git

BUG/MINOR: backend: Don't allow to change backend applet

This part was inherited from haproxy-1.5. But since a while (at least 1.8),
the backend applet, once created, is no longer changed. Thus there is no
reason to still check if the target has changed. And in fact, if it was
still possible, there would be a memory leak because the old applet would be
lost and never released.

There is no reason to backport this fix because the leak only exists on a
dead code path.
---

diff --git a/src/backend.c b/src/backend.c
index 8255ffbe72..12f9a651b6 100644
--- a/src/backend.c
+++ b/src/backend.c
@@ -2129,7 +2129,7 @@ void back_handle_st_req(struct stream *s)
 		/* the applet directly goes to the EST state */
 		struct appctx *appctx = cs_appctx(s->csb);
 
-		if (!appctx || appctx->applet != __objt_applet(s->target))
+		if (!appctx)
 			appctx = cs_applet_create(cs, objt_applet(s->target));
 
 		if (!appctx) {