From: John Garry Date: Thu, 23 Oct 2025 08:54:51 +0000 (+0000) Subject: scsi: advansys: Don't call asc_prt_scsi_host() -> scsi_host_busy() X-Git-Tag: v6.19-rc1~95^2~38 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=bb798c1f43c0010d792b93dc9cbb9cef7a052f61;p=thirdparty%2Fkernel%2Flinux.git scsi: advansys: Don't call asc_prt_scsi_host() -> scsi_host_busy() The driver calls asc_prt_scsi_host() -> scsi_host_busy() prior to calling scsi_add_host(). This should not be done, and has raised issues for other drivers, like [0]. Function asc_prt_scsi_host() only has a single callsite, as above, where the shost busy count would always be 0. Avoid printing the shost busy count to avoid this problem. [0] https://lore.kernel.org/linux-scsi/20251014200118.3390839-3-bvanassche@acm.org/ Reported-by: Bart Van Assche Signed-off-by: John Garry Reviewed-by: Bart Van Assche Link: https://patch.msgid.link/20251023085451.3933666-1-john.g.garry@oracle.com Signed-off-by: Martin K. Petersen --- diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c index 063e1b5818d34..06223b5ee6dae 100644 --- a/drivers/scsi/advansys.c +++ b/drivers/scsi/advansys.c @@ -2401,8 +2401,7 @@ static void asc_prt_scsi_host(struct Scsi_Host *s) struct asc_board *boardp = shost_priv(s); printk("Scsi_Host at addr 0x%p, device %s\n", s, dev_name(boardp->dev)); - printk(" host_busy %d, host_no %d,\n", - scsi_host_busy(s), s->host_no); + printk(" host_no %d,\n", s->host_no); printk(" base 0x%lx, io_port 0x%lx, irq %d,\n", (ulong)s->base, (ulong)s->io_port, boardp->irq);