From: Piotr Trojanek <trojanek@adacore.com>
Date: Tue, 4 Mar 2025 11:33:34 +0000 (+0100)
Subject: ada: Check validity using signedness from the type and not its base type
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=bba4596132cb75d2892e7475aa67d32e15439c39;p=thirdparty%2Fgcc.git

ada: Check validity using signedness from the type and not its base type

When attribute Valid is applied to a private type, we used the signedness of
its implementation base type which wrongly included negative values.

gcc/ada/ChangeLog:

	* exp_attr.adb (Expand_N_Attribute_Reference): When expanding attribute
	Valid, use signedness from the validated view, not from its base type.
---

diff --git a/gcc/ada/exp_attr.adb b/gcc/ada/exp_attr.adb
index f1f8424d720..3d1bff93b40 100644
--- a/gcc/ada/exp_attr.adb
+++ b/gcc/ada/exp_attr.adb
@@ -8183,9 +8183,8 @@ package body Exp_Attr is
          else
             declare
                Uns  : constant Boolean :=
-                        Is_Unsigned_Type (Ptyp)
-                          or else (Is_Private_Type (Ptyp)
-                                    and then Is_Unsigned_Type (PBtyp));
+                 Is_Unsigned_Type (Validated_View (Ptyp));
+
                Size : Uint;
                P    : Node_Id := Pref;