From: Zheng Liang <zhengliang6@huawei.com>
Date: Thu, 12 Nov 2020 09:25:30 +0000 (+0800)
Subject: mmc: mediatek: fix mem leak in msdc_drv_probe
X-Git-Tag: v5.11-rc1~156^2~34
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=bbba85fae44134e00c493705bd5604fd63958315;p=thirdparty%2Flinux.git

mmc: mediatek: fix mem leak in msdc_drv_probe

It should use mmc_free_host to free mem in error patch of
msdc_drv_probe.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zheng Liang <zhengliang6@huawei.com>
Reviewed-by: Chaotian Jing <chaotian.jing@mediatek.com>
Link: https://lore.kernel.org/r/20201112092530.32446-1-zhengliang6@huawei.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---

diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index fc5ee5df91adf..eac7838e2dac3 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -2504,8 +2504,10 @@ static int msdc_drv_probe(struct platform_device *pdev)
 
 	host->reset = devm_reset_control_get_optional_exclusive(&pdev->dev,
 								"hrst");
-	if (IS_ERR(host->reset))
-		return PTR_ERR(host->reset);
+	if (IS_ERR(host->reset)) {
+		ret = PTR_ERR(host->reset);
+		goto host_free;
+	}
 
 	host->irq = platform_get_irq(pdev, 0);
 	if (host->irq < 0) {