From: Dan Carpenter Date: Fri, 26 Sep 2025 04:03:29 +0000 (+0300) Subject: pmdomain: thead: Fix error pointer vs NULL bug in th1520_pd_reboot_init() X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=bbc3110823eca23b066e75a920bdc8118adda0d2;p=thirdparty%2Fkernel%2Fstable.git pmdomain: thead: Fix error pointer vs NULL bug in th1520_pd_reboot_init() The devm_auxiliary_device_create() returns NULL on error. It never returns error pointers. Using PTR_ERR_OR_ZERO() here means the function always returns success. Replace the PTR_ERR_OR_ZERO() call check with a NULL check. Fixes: 64581f41f4c4 ("pmdomain: thead: create auxiliary device for rebooting") Signed-off-by: Dan Carpenter Acked-by: Icenowy Zheng Signed-off-by: Ulf Hansson --- diff --git a/drivers/pmdomain/thead/th1520-pm-domains.c b/drivers/pmdomain/thead/th1520-pm-domains.c index 5213994101a5..d7cb9633c7c8 100644 --- a/drivers/pmdomain/thead/th1520-pm-domains.c +++ b/drivers/pmdomain/thead/th1520-pm-domains.c @@ -179,8 +179,10 @@ static int th1520_pd_reboot_init(struct device *dev, struct auxiliary_device *adev; adev = devm_auxiliary_device_create(dev, "reboot", aon_chan); + if (!adev) + return -ENODEV; - return PTR_ERR_OR_ZERO(adev); + return 0; } static int th1520_pd_probe(struct platform_device *pdev)