From: Neo Jou Date: Tue, 21 May 2019 09:12:20 +0000 (+0800) Subject: brcmfmac: use strlcpy() instead of strcpy() X-Git-Tag: v5.3-rc1~140^2~141^2~50 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=bbfab331e3abd9fa8767eea6bf5c4684cdd4b934;p=thirdparty%2Fkernel%2Flinux.git brcmfmac: use strlcpy() instead of strcpy() The function strcpy() is inherently not safe. Though the function works without problems here, it would be better to use other safer function, e.g. strlcpy(), to replace strcpy() still. Signed-off-by: Neo Jou Signed-off-by: Kalle Valo --- diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c index 7c9d06d525b13..aa89d620ee5d4 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c @@ -258,7 +258,7 @@ int brcmf_c_preinit_dcmds(struct brcmf_if *ifp) /* query for 'ver' to get version info from firmware */ memset(buf, 0, sizeof(buf)); - strcpy(buf, "ver"); + strlcpy(buf, "ver", sizeof(buf)); err = brcmf_fil_iovar_data_get(ifp, "ver", buf, sizeof(buf)); if (err < 0) { bphy_err(drvr, "Retrieving version information failed, %d\n",