From: Tobias Stoeckmann <tobias@stoeckmann.org>
Date: Sat, 3 Feb 2024 00:07:58 +0000 (+0100)
Subject: lib/chkname.c: Take NUL byte into account
X-Git-Tag: 4.14.4~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=bc0151d4d30674224fab01884ba62f10a5b63084;p=thirdparty%2Fshadow.git

lib/chkname.c: Take NUL byte into account

The _SC_LOGIN_NAME_MAX value includes space for the NUL byte.  The
length of name must smaller than this value to be valid.

Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
Cherry-picked-from: 403a2e3771be ("lib/chkname.c: Take NUL byte into account")
Link: <https://github.com/shadow-maint/shadow/pull/935>
Cc: Serge Hallyn <serge@hallyn.com>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
---

diff --git a/lib/chkname.c b/lib/chkname.c
index d22e1b6b4..d14e44a59 100644
--- a/lib/chkname.c
+++ b/lib/chkname.c
@@ -80,7 +80,7 @@ bool is_valid_user_name (const char *name)
 	 * User names length are limited by the kernel
 	 */
 	maxlen = sysconf(_SC_LOGIN_NAME_MAX);
-	if (strlen(name) > maxlen)
+	if (strlen(name) >= maxlen)
 		return false;
 
 	return is_valid_name (name);