From: Jocelyn Falempe Date: Thu, 12 Dec 2024 09:11:29 +0000 (+0100) Subject: drm/client: Fix drm client endless Kconfig loop X-Git-Tag: v6.14-rc1~174^2~13^2~74 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=bc0e01b53614d3d6bb80c7b97ab26a609ba394e9;p=thirdparty%2Fkernel%2Flinux.git drm/client: Fix drm client endless Kconfig loop if DRM_CLIENT_SELECTION is enabled, and none of the client is, the "Default DRM Client" choice is empty, and this makes Kconfig goes into an infinite loop of: Default DRM Client choice[1-0?]: 0 Default DRM Client choice[1-0?]: 0 Default DRM Client choice[1-0?]: 0 .... So only allow the choice if at least one of the client is selected. Fixes: f7b42442c4ac ("drm/log: Introduce a new boot logger to draw the kmsg on the screen") Reported-by: Dan Carpenter Closes: https://lore.kernel.org/dri-devel/20241204160014.1171469-1-jfalempe@redhat.com/T/#md78853bba8904fd7614073f280f721d13ab0b432 Signed-off-by: Jocelyn Falempe Tested-by: Dan Carpenter Acked-by: Simona Vetter Link: https://patchwork.freedesktop.org/patch/msgid/20241212091153.1592096-1-jfalempe@redhat.com --- diff --git a/drivers/gpu/drm/clients/Kconfig b/drivers/gpu/drm/clients/Kconfig index c18decc902001..82a7d4e584ddb 100644 --- a/drivers/gpu/drm/clients/Kconfig +++ b/drivers/gpu/drm/clients/Kconfig @@ -87,6 +87,7 @@ config DRM_CLIENT_LOG choice prompt "Default DRM Client" depends on DRM_CLIENT_SELECTION + depends on DRM_FBDEV_EMULATION || DRM_CLIENT_LOG default DRM_CLIENT_DEFAULT_FBDEV help Selects the default drm client.