From: Andrii Nakryiko <andriin@fb.com>
Date: Fri, 17 Jan 2020 06:07:58 +0000 (-0800)
Subject: libbpf: Fix error handling bug in btf_dump__new
X-Git-Tag: v5.6-rc1~151^2~46^2~15
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=bc0eb9a333918d2cc4f42f7f4cf09eaf029ac9de;p=thirdparty%2Fkernel%2Flinux.git

libbpf: Fix error handling bug in btf_dump__new

Fix missing jump to error handling in btf_dump__new, found by Coverity static
code analysis.

Fixes: 9f81654eebe8 ("libbpf: Expose BTF-to-C type declaration emitting API")
Signed-off-by: Andrii Nakryiko <andriin@fb.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Link: https://lore.kernel.org/bpf/20200117060801.1311525-2-andriin@fb.com
---

diff --git a/tools/lib/bpf/btf_dump.c b/tools/lib/bpf/btf_dump.c
index 885acebd43964..bd09ed1710f12 100644
--- a/tools/lib/bpf/btf_dump.c
+++ b/tools/lib/bpf/btf_dump.c
@@ -142,6 +142,7 @@ struct btf_dump *btf_dump__new(const struct btf *btf,
 	if (IS_ERR(d->type_names)) {
 		err = PTR_ERR(d->type_names);
 		d->type_names = NULL;
+		goto err;
 	}
 	d->ident_names = hashmap__new(str_hash_fn, str_equal_fn, NULL);
 	if (IS_ERR(d->ident_names)) {