From: Daniel Stenberg <daniel@haxx.se>
Date: Wed, 23 Nov 2016 06:52:38 +0000 (+0100)
Subject: checksrc: add ASTERISKSPACE
X-Git-Tag: curl-7_52_0~92
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=bc7e08471c1884a5100b6e0513a006c263ec3c6b;p=thirdparty%2Fcurl.git

checksrc: add ASTERISKSPACE

Verifies a 'char *name' style, with no space after the asterisk.
---

diff --git a/lib/checksrc.pl b/lib/checksrc.pl
index 83c38b2394..9eb76f47ef 100755
--- a/lib/checksrc.pl
+++ b/lib/checksrc.pl
@@ -55,7 +55,8 @@ my %warnings = (
     'COPYRIGHT'        => 'file missing a copyright statement',
     'BADCOMMAND'       => 'bad !checksrc! instruction',
     'UNUSEDIGNORE'     => 'a warning ignore was not used',
-    'OPENCOMMENT'      => 'file ended with a /* comment still "open"'
+    'OPENCOMMENT'      => 'file ended with a /* comment still "open"',
+    'ASTERISKSPACE'    => 'pointer declared with space after asterisk'
     );
 
 sub readwhitelist {
@@ -471,6 +472,12 @@ sub scanfile {
             }
         }
 
+        # check for 'char * name'
+        if(($l =~ /(^.*(char|int|long|void|curl_slist|CURL|CURLM|CURLMsg|curl_httppost) *\*) (\w+)/) && ($3 ne "const")) {
+            checkwarn("ASTERISKSPACE",
+                      $line, length($1), $file, $ol,
+                      "no space after declarative asterisk");
+        }
         $line++;
         $prevl = $ol;
     }