From: Stefan Hajnoczi <stefanha@redhat.com>
Date: Wed, 9 Oct 2019 13:51:54 +0000 (+0100)
Subject: trace: add --group=all to tracing.txt
X-Git-Tag: v4.2.0-rc0~58^2~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=bd200384c515bdc84d52f1735c0fea43c8f61e11;p=thirdparty%2Fqemu.git

trace: add --group=all to tracing.txt

tracetool needs to know the group name ("all", "root", or a specific
subdirectory).  Also remove the stdin redirection because tracetool.py
needs the path to the trace-events file.  Update the documentation.

Fixes: 2098c56a9bc5901e145fa5d4759f075808811685
       ("trace: move setting of group name into Makefiles")
Buglink: https://bugs.launchpad.net/bugs/1844814
Reported-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20191009135154.10970-1-stefanha@redhat.com>
---

diff --git a/docs/devel/tracing.txt b/docs/devel/tracing.txt
index 8231bbf5d19..8c0376fefa4 100644
--- a/docs/devel/tracing.txt
+++ b/docs/devel/tracing.txt
@@ -317,7 +317,8 @@ probes:
                          --binary path/to/qemu-binary \
                          --target-type system \
                          --target-name x86_64 \
-                         <trace-events-all >qemu.stp
+                         --group=all \
+                         trace-events-all >qemu.stp
 
 To facilitate simple usage of systemtap where there merely needs to be printf
 logging of certain probes, a helper script "qemu-trace-stap" is provided.