From: Jouni Malinen <j@w1.fi>
Date: Fri, 11 Apr 2014 20:47:46 +0000 (+0300)
Subject: Fix ctrl_iface BLACKLIST return value
X-Git-Tag: hostap_2_2~322
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=bd8838a387ef7b71190ecba360596db129c7f430;p=thirdparty%2Fhostap.git

Fix ctrl_iface BLACKLIST return value

Adding a new entry was returning FAIL on success due to incorrect
assumption of wpa_blacklist_add() returning 0 on success (it returns the
positive blacklist count).

Signed-off-by: Jouni Malinen <j@w1.fi>
---

diff --git a/wpa_supplicant/ctrl_iface.c b/wpa_supplicant/ctrl_iface.c
index 01be08985..2f5768397 100644
--- a/wpa_supplicant/ctrl_iface.c
+++ b/wpa_supplicant/ctrl_iface.c
@@ -1861,10 +1861,10 @@ static int wpa_supplicant_ctrl_iface_blacklist(struct wpa_supplicant *wpa_s,
 	 * skipped when processing scan results.
 	 */
 	ret = wpa_blacklist_add(wpa_s, bssid);
-	if (ret != 0)
+	if (ret < 0)
 		return -1;
 	ret = wpa_blacklist_add(wpa_s, bssid);
-	if (ret != 0)
+	if (ret < 0)
 		return -1;
 	os_memcpy(buf, "OK\n", 3);
 	return 3;