From: Tobias Brunner <tobias@strongswan.org>
Date: Tue, 13 Sep 2022 14:10:55 +0000 (+0200)
Subject: unit-tests: Don't use test data on stack for TLS socket tests
X-Git-Tag: 5.9.8dr4~11^2~8
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=bdc7f84a234550c8879d4e25e520c6ac66e4a37c;p=thirdparty%2Fstrongswan.git

unit-tests: Don't use test data on stack for TLS socket tests

The stack of that function might not be valid anymore once data is read.
---

diff --git a/src/libtls/tests/suites/test_socket.c b/src/libtls/tests/suites/test_socket.c
index 2c75d9efc3..91ee58b975 100644
--- a/src/libtls/tests/suites/test_socket.c
+++ b/src/libtls/tests/suites/test_socket.c
@@ -647,6 +647,11 @@ static void run_echo_client(echo_server_config_t *config)
 	server->destroy(server);
 }
 
+/**
+ * Data for echo test
+ */
+static chunk_t echo_data = chunk_from_chars(0x01,0x02,0x03,0x04,0x05,0x06,0x07,0x08);
+
 /**
  * Create server/peer configuration
  */
@@ -660,7 +665,7 @@ static echo_server_config_t *create_config(tls_version_t version, uint16_t port,
 		.addr = "127.0.0.1",
 		.port = port,
 		.cauth = cauth,
-		.data = chunk_from_chars(0x01,0x02,0x03,0x04,0x05,0x06,0x07,0x08),
+		.data = echo_data,
 	);
 	return config;
 }