From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date: Thu, 23 Nov 2023 21:16:59 +0000 (+0100)
Subject: remoteproc: k3-dsp: Suppress duplicate error message in .remove()
X-Git-Tag: v6.8-rc1~71^2~5
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=bddae3e7ae70586b3805fdbce193760f13b4d73e;p=thirdparty%2Fkernel%2Flinux.git

remoteproc: k3-dsp: Suppress duplicate error message in .remove()

When the remove callback returns non-zero, the driver core emits an
error message about the error value being ignored. As the driver already
emits an error message already, return zero. This has no effect apart
from suppressing the core's message. The platform device gets unbound
irrespective of the return value.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20231123211657.518181-6-u.kleine-koenig@pengutronix.de
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
---

diff --git a/drivers/remoteproc/ti_k3_dsp_remoteproc.c b/drivers/remoteproc/ti_k3_dsp_remoteproc.c
index ef8415a7cd542..40a5fd8763faf 100644
--- a/drivers/remoteproc/ti_k3_dsp_remoteproc.c
+++ b/drivers/remoteproc/ti_k3_dsp_remoteproc.c
@@ -835,8 +835,9 @@ static int k3_dsp_rproc_remove(struct platform_device *pdev)
 	if (rproc->state == RPROC_ATTACHED) {
 		ret = rproc_detach(rproc);
 		if (ret) {
+			/* Note this error path leaks resources */
 			dev_err(dev, "failed to detach proc, ret = %d\n", ret);
-			return ret;
+			return 0;
 		}
 	}