From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Fri, 13 Jun 2025 10:05:46 +0000 (+0200)
Subject: dnsdist: Apply Otto's suggestion of reordering ancount/arcount
X-Git-Tag: dnsdist-2.0.0-beta1~21^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=be0bcaed7f25ae10d6857ec77e95be972dd52038;p=thirdparty%2Fpdns.git

dnsdist: Apply Otto's suggestion of reordering ancount/arcount

Co-authored-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Signed-off-by: Remi Gacogne <github@coredump.fr>
---

diff --git a/pdns/dnsdistdist/dnsdist-self-answers.cc b/pdns/dnsdistdist/dnsdist-self-answers.cc
index d18f563ff9..123ebd8d76 100644
--- a/pdns/dnsdistdist/dnsdist-self-answers.cc
+++ b/pdns/dnsdistdist/dnsdist-self-answers.cc
@@ -253,9 +253,9 @@ bool removeRecordsAndSetRCode(DNSQuestion& dnsQuestion, uint8_t rcode)
     header.rcode = rcode;
     header.qr = true;
     header.qdcount = htons(1);
-    header.arcount = 0;
-    header.nscount = 0;
     header.ancount = 0;
+    header.nscount = 0;
+    header.arcount = 0;
     return true;
   });
   auto qnameWireLength = dnsQuestion.ids.qname.wirelength();