From: Nathan Chancellor Date: Tue, 15 Oct 2024 20:09:02 +0000 (-0700) Subject: staging: gpib: fmh: Drop residue from fmh_gpid_fifo_read_countable() X-Git-Tag: v6.13-rc1~30^2~104 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=be11b268e58d35ee394f6caf4056fa82f032eb65;p=thirdparty%2Fkernel%2Flinux.git staging: gpib: fmh: Drop residue from fmh_gpid_fifo_read_countable() Clang warns (or errors with CONFIG_WERROR=y): drivers/staging/gpib/fmh_gpib/fmh_gpib.c:970:43: error: variable 'residue' is uninitialized when used here [-Werror,-Wuninitialized] 970 | (int)(*bytes_read), (int)length, (int)residue); | ^~~~~~~ residue is never initialized in this function and it is not used outside of an error print. Just remove it altogether, as it is likely not necessary in this function, as this same exact statement in present in fmh_gpib_dma_read(). Fixes: 8e4841a0888c ("staging: gpib: Add Frank Mori Hess FPGA PCI GPIB driver") Signed-off-by: Nathan Chancellor Link: https://lore.kernel.org/r/20241015-staging-gpib-fmh-fix-residue-used-uninitialized-v1-1-23ef05b099da@kernel.org Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/gpib/fmh_gpib/fmh_gpib.c b/drivers/staging/gpib/fmh_gpib/fmh_gpib.c index 07c75ba8df7c5..0e27b3ef1a1df 100644 --- a/drivers/staging/gpib/fmh_gpib/fmh_gpib.c +++ b/drivers/staging/gpib/fmh_gpib/fmh_gpib.c @@ -922,7 +922,6 @@ static int fmh_gpib_fifo_read_countable(gpib_board_t *board, uint8_t *buffer, struct fmh_priv *e_priv = board->private_data; struct nec7210_priv *nec_priv = &e_priv->nec7210_priv; int retval = 0; - unsigned int residue; // printk("%s: enter, bus_address=0x%x, length=%i\n", __FUNCTION__, // (unsigned)bus_address, @@ -966,8 +965,8 @@ cleanup: unsigned int data_value; if ((*bytes_read) >= length) { - dev_err(board->dev, "unexpected extra bytes in rx fifo, discarding! bytes_read=%d length=%d residue=%d\n", - (int)(*bytes_read), (int)length, (int)residue); + dev_err(board->dev, "unexpected extra bytes in rx fifo, discarding! bytes_read=%d length=%d\n", + (int)(*bytes_read), (int)length); break; } data_value = fifos_read(e_priv, FIFO_DATA_REG); @@ -976,8 +975,8 @@ cleanup: *end = 1; } -// printk("\tbytes_read=%i, residue=%i, end=%i, retval=%i, wait_retval=%i\n", -// *bytes_read, residue, *end, retval, wait_retval); +// printk("\tbytes_read=%i, end=%i, retval=%i, wait_retval=%i\n", +// *bytes_read, *end, retval, wait_retval); return retval; }