From: Karel Zak <kzak@redhat.com>
Date: Wed, 11 Oct 2017 13:13:44 +0000 (+0200)
Subject: lslogins: fix possible memory leak [coverity scan]
X-Git-Tag: v2.31~20
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=be642826658afc3c5c642b917414121cf6f9290e;p=thirdparty%2Futil-linux.git

lslogins: fix possible memory leak [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>
---

diff --git a/login-utils/lslogins.c b/login-utils/lslogins.c
index 5d896d73c0..1042b9b41c 100644
--- a/login-utils/lslogins.c
+++ b/login-utils/lslogins.c
@@ -606,12 +606,12 @@ static struct lslogins_user *get_user_info(struct lslogins_control *ctl, const c
 		return NULL;
 	}
 
-	user = xcalloc(1, sizeof(struct lslogins_user));
-
 	grp = getgrgid(pwd->pw_gid);
 	if (!grp)
 		return NULL;
 
+	user = xcalloc(1, sizeof(struct lslogins_user));
+
 	if (ctl->wtmp)
 		user_wtmp = get_last_wtmp(ctl, pwd->pw_name);
 	if (ctl->btmp)