From: Sasha Levin <sashal@kernel.org>
Date: Thu, 13 Apr 2023 02:31:14 +0000 (-0400)
Subject: Fixes for 5.10
X-Git-Tag: v5.15.107~1^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=be828ba1e16a7484bcccfdc17d0d331848fd43ee;p=thirdparty%2Fkernel%2Fstable-queue.git

Fixes for 5.10

Signed-off-by: Sasha Levin <sashal@kernel.org>
---

diff --git a/queue-5.10/bpftool-print-newline-before-for-struct-with-padding.patch b/queue-5.10/bpftool-print-newline-before-for-struct-with-padding.patch
new file mode 100644
index 00000000000..783bd23767f
--- /dev/null
+++ b/queue-5.10/bpftool-print-newline-before-for-struct-with-padding.patch
@@ -0,0 +1,55 @@
+From 55884de95fc21bea9190fff34e03e1144adc53f5 Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Sat, 1 Oct 2022 13:44:24 +0300
+Subject: bpftool: Print newline before '}' for struct with padding only fields
+
+From: Eduard Zingerman <eddyz87@gmail.com>
+
+[ Upstream commit 44a726c3f23cf762ef4ce3c1709aefbcbe97f62c ]
+
+btf_dump_emit_struct_def attempts to print empty structures at a
+single line, e.g. `struct empty {}`. However, it has to account for a
+case when there are no regular but some padding fields in the struct.
+In such case `vlen` would be zero, but size would be non-zero.
+
+E.g. here is struct bpf_timer from vmlinux.h before this patch:
+
+ struct bpf_timer {
+ 	long: 64;
+	long: 64;};
+
+And after this patch:
+
+ struct bpf_dynptr {
+ 	long: 64;
+	long: 64;
+ };
+
+Signed-off-by: Eduard Zingerman <eddyz87@gmail.com>
+Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
+Link: https://lore.kernel.org/bpf/20221001104425.415768-1-eddyz87@gmail.com
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ tools/lib/bpf/btf_dump.c | 6 +++++-
+ 1 file changed, 5 insertions(+), 1 deletion(-)
+
+diff --git a/tools/lib/bpf/btf_dump.c b/tools/lib/bpf/btf_dump.c
+index 558d34fbd331c..6a8d8ed34b760 100644
+--- a/tools/lib/bpf/btf_dump.c
++++ b/tools/lib/bpf/btf_dump.c
+@@ -969,7 +969,11 @@ static void btf_dump_emit_struct_def(struct btf_dump *d,
+ 	if (is_struct)
+ 		btf_dump_emit_bit_padding(d, off, t->size * 8, align, false, lvl + 1);
+ 
+-	if (vlen)
++	/*
++	 * Keep `struct empty {}` on a single line,
++	 * only print newline when there are regular or padding fields.
++	 */
++	if (vlen || t->size)
+ 		btf_dump_printf(d, "\n");
+ 	btf_dump_printf(d, "%s}", pfx(lvl));
+ 	if (packed)
+-- 
+2.39.2
+
diff --git a/queue-5.10/series b/queue-5.10/series
index cd38aecbacc..436aa55a9c6 100644
--- a/queue-5.10/series
+++ b/queue-5.10/series
@@ -49,3 +49,4 @@ selftests-intel_pstate-ftime-is-deprecated.patch
 drm-bridge-lt9611-fix-pll-being-unable-to-lock.patch
 revert-media-ti-cal-fix-possible-memory-leak-in-cal_ctx_create.patch
 ocfs2-fix-freeing-uninitialized-resource-on-ocfs2_dlm_shutdown.patch
+bpftool-print-newline-before-for-struct-with-padding.patch