From: Ido Schimmel Date: Wed, 21 Aug 2024 12:52:51 +0000 (+0300) Subject: ipv4: Unmask upper DSCP bits when using hints X-Git-Tag: v6.12-rc1~232^2~198^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=be8b8ded77996cfcd1bb2f1d97b91106d5882877;p=thirdparty%2Fkernel%2Flinux.git ipv4: Unmask upper DSCP bits when using hints Unmask the upper DSCP bits when performing source validation and routing a packet using the same route from a previously processed packet (hint). In the future, this will allow us to perform the FIB lookup that is performed as part of source validation according to the full DSCP value. No functional changes intended since the upper DSCP bits are masked when comparing against the TOS selectors in FIB rules and routes. Signed-off-by: Ido Schimmel Reviewed-by: Guillaume Nault Acked-by: Florian Westphal Reviewed-by: David Ahern Link: https://patch.msgid.link/20240821125251.1571445-13-idosch@nvidia.com Signed-off-by: Jakub Kicinski --- diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 524b70ab77a0e..f6972b24664a0 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -2160,7 +2160,7 @@ int ip_route_use_hint(struct sk_buff *skb, __be32 daddr, __be32 saddr, if (rt->rt_type != RTN_LOCAL) goto skip_validate_source; - tos &= IPTOS_RT_MASK; + tos &= INET_DSCP_MASK; err = fib_validate_source(skb, saddr, daddr, tos, 0, dev, in_dev, &tag); if (err < 0) goto martian_source;