From: Tom Lane Date: Thu, 28 Mar 2024 15:44:00 +0000 (-0400) Subject: Update comment in set_dummy_rel_pathlist(). X-Git-Tag: REL_17_BETA1~483 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=be98a550cc81994959f19a117cb2732762df924c;p=thirdparty%2Fpostgresql.git Update comment in set_dummy_rel_pathlist(). This comment claimed that set_dummy_rel_pathlist() has callers other than (possibly indirectly) set_rel_size(). It doesn't, so revise the argument to not rely on that. Noted by Richard Guo. Discussion: https://postgr.es/m/CAMbWs4-KFEU_fDuJPNCOkUu3rwvZvKBEytkd9VrM4kH4-2h1CQ@mail.gmail.com --- diff --git a/src/backend/optimizer/path/allpaths.c b/src/backend/optimizer/path/allpaths.c index 7bad4044580..3151ad1f64b 100644 --- a/src/backend/optimizer/path/allpaths.c +++ b/src/backend/optimizer/path/allpaths.c @@ -2180,9 +2180,9 @@ set_dummy_rel_pathlist(RelOptInfo *rel) /* * We set the cheapest-path fields immediately, just in case they were - * pointing at some discarded path. This is redundant when we're called - * from set_rel_size(), but not when called from elsewhere, and doing it - * twice is harmless anyway. + * pointing at some discarded path. This is redundant in current usage + * because set_rel_pathlist will do it later, but it's cheap so we keep it + * for safety and consistency with mark_dummy_rel. */ set_cheapest(rel); }