From: Laine Stump <laine@redhat.com>
Date: Wed, 12 Feb 2025 03:53:30 +0000 (-0500)
Subject: conf: change virDomainDefMaybeAddVirtioSerialController() to return void
X-Git-Tag: v11.2.0-rc1~273
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=be9a0f47646d1ebb9651c1a58ffb30352596ecef;p=thirdparty%2Flibvirt.git

conf: change virDomainDefMaybeAddVirtioSerialController() to return void

It can't fail.

Signed-off-by: Laine Stump <laine@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
---

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index ec72bb5117..64ec520589 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -22275,7 +22275,7 @@ virDomainDefAddDiskControllersForType(virDomainDef *def,
 }
 
 
-static int
+static void
 virDomainDefMaybeAddVirtioSerialController(virDomainDef *def)
 {
     /* Look for any virtio serial or virtio console devs */
@@ -22304,8 +22304,6 @@ virDomainDefMaybeAddVirtioSerialController(virDomainDef *def)
             virDomainDefMaybeAddController(def, VIR_DOMAIN_CONTROLLER_TYPE_VIRTIO_SERIAL, idx, -1);
         }
     }
-
-    return 0;
 }
 
 
@@ -22362,8 +22360,7 @@ virDomainDefAddImplicitControllers(virDomainDef *def)
     virDomainDefAddDiskControllersForType(def, VIR_DOMAIN_CONTROLLER_TYPE_SATA,
                                           VIR_DOMAIN_DISK_BUS_SATA);
 
-    if (virDomainDefMaybeAddVirtioSerialController(def) < 0)
-        return -1;
+    virDomainDefMaybeAddVirtioSerialController(def);
 
     if (virDomainDefMaybeAddSmartcardController(def) < 0)
         return -1;