From: Stephan Bosch <stephan.bosch@dovecot.fi>
Date: Sun, 16 Sep 2018 19:55:58 +0000 (+0200)
Subject: lib-smtp: params: Fix segfault occurring in smtp_param_write() when param->value... 
X-Git-Tag: 2.3.9~1241
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=bea8658fe2d60dc82c0ff4f703df0a9e5408e96f;p=thirdparty%2Fdovecot%2Fcore.git

lib-smtp: params: Fix segfault occurring in smtp_param_write() when param->value == NULL.
---

diff --git a/src/lib-smtp/smtp-params.c b/src/lib-smtp/smtp-params.c
index 3c8178ef58..8e9786f765 100644
--- a/src/lib-smtp/smtp-params.c
+++ b/src/lib-smtp/smtp-params.c
@@ -100,10 +100,12 @@ static bool smtp_param_value_valid(const char *value)
 
 void smtp_param_write(string_t *out, const struct smtp_param *param)
 {
-	i_assert(smtp_param_value_valid(param->value));
 	str_append(out, t_str_ucase(param->keyword));
-	str_append_c(out, '=');
-	str_append(out, param->value);
+	if (param->value != NULL) {
+		i_assert(smtp_param_value_valid(param->value));
+		str_append_c(out, '=');
+		str_append(out, param->value);
+	}
 }
 
 /*