From: Daniel Stenberg <daniel@haxx.se>
Date: Wed, 9 Mar 2022 10:43:24 +0000 (+0100)
Subject: tool_operate: fix a scan-build warning
X-Git-Tag: curl-7_83_0~167
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=bec62e39d1b0421219074b9d72276b64800c69b7;p=thirdparty%2Fcurl.git

tool_operate: fix a scan-build warning

... and avoid the temp storing of the return code in a diff variable.

Closes #8565
---

diff --git a/src/tool_operate.c b/src/tool_operate.c
index 05296c9e75..37ff44795f 100644
--- a/src/tool_operate.c
+++ b/src/tool_operate.c
@@ -1736,20 +1736,17 @@ static CURLcode single_transfer(struct GlobalConfig *global,
         if(config->cookies) {
           struct curlx_dynbuf cookies;
           struct curl_slist *cl;
-          CURLcode ret;
 
           /* The maximum size needs to match MAX_NAME in cookie.h */
           curlx_dyn_init(&cookies, 4096);
           for(cl = config->cookies; cl; cl = cl->next) {
             if(cl == config->cookies)
-              ret = curlx_dyn_addf(&cookies, "%s", cl->data);
+              result = curlx_dyn_addf(&cookies, "%s", cl->data);
             else
-              ret = curlx_dyn_addf(&cookies, ";%s", cl->data);
+              result = curlx_dyn_addf(&cookies, ";%s", cl->data);
 
-            if(ret) {
-              result = CURLE_OUT_OF_MEMORY;
+            if(result)
               break;
-            }
           }
 
           my_setopt_str(curl, CURLOPT_COOKIE, curlx_dyn_ptr(&cookies));