From: Lidong Yan <502024330056@smail.nju.edu.cn> Date: Fri, 9 May 2025 08:30:35 +0000 (+0000) Subject: commit-graph: fix memory leak when `fill_oids_from_packs()` fails X-Git-Tag: v2.50.0-rc0~14^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=beccbddb6802c0b56e34bb1d55cecceb093940f4;p=thirdparty%2Fgit.git commit-graph: fix memory leak when `fill_oids_from_packs()` fails In commit-graph.c:fill_oids_from_packs, if open_pack_index failed, memory allocated and returned by add_packed_git will leak. Simply add close_pack and free(p) will solve this problem. Signed-off-by: Lidong Yan <502024330056@smail.nju.edu.cn> Signed-off-by: Junio C Hamano --- diff --git a/commit-graph.c b/commit-graph.c index 6394752b0b..93d867770b 100644 --- a/commit-graph.c +++ b/commit-graph.c @@ -1929,6 +1929,8 @@ static int fill_oids_from_packs(struct write_commit_graph_context *ctx, } if (open_pack_index(p)) { ret = error(_("error opening index for %s"), packname.buf); + close_pack(p); + free(p); goto cleanup; } for_each_object_in_pack(p, add_packed_commits, ctx,