From: Jeff Davis <jdavis@postgresql.org>
Date: Sat, 23 Mar 2024 20:37:08 +0000 (-0700)
Subject: Remove incorrect Assert introduced in c8aeaf3ab.
X-Git-Tag: REL_13_15~39
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=bf038eb219bb6c7dc8a8de58de3513c035a5efba;p=thirdparty%2Fpostgresql.git

Remove incorrect Assert introduced in c8aeaf3ab.

Already removed incidentally in version 15 (c4649cce3), so this commit
is only applied to versions 13 and 14.

The comment above is misleading in all versions 13 and later, so that
will be fixed in a separate commit.

Discussion: https://postgr.es/m/cfd84cb8-12fe-433a-a4bb-f460a4515f9c.zhaotinghai.zth%40alibaba-inc.com
Reported-by: Tinghai Zhao
Backpatch-through: 13
---

diff --git a/src/backend/utils/sort/logtape.c b/src/backend/utils/sort/logtape.c
index 720f9dfe2b7..95b174fc7e8 100644
--- a/src/backend/utils/sort/logtape.c
+++ b/src/backend/utils/sort/logtape.c
@@ -1269,12 +1269,5 @@ LogicalTapeTell(LogicalTapeSet *lts, int tapenum,
 long
 LogicalTapeSetBlocks(LogicalTapeSet *lts)
 {
-#ifdef USE_ASSERT_CHECKING
-	for (int i = 0; i < lts->nTapes; i++)
-	{
-		LogicalTape *lt = &lts->tapes[i];
-		Assert(!lt->writing || lt->buffer == NULL);
-	}
-#endif
 	return lts->nBlocksWritten - lts->nHoleBlocks;
 }