From: YueHaibing <yuehaibing@huawei.com>
Date: Wed, 23 Jan 2019 07:05:07 +0000 (+0800)
Subject: spi: bcm2835aux: remove unneeded NULL check of devm_clk_get
X-Git-Tag: v5.1-rc1~181^2^2~47
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=bfc7af6d6df8d75b9c693b8eb98c21aa75c1e377;p=thirdparty%2Fkernel%2Flinux.git

spi: bcm2835aux: remove unneeded NULL check of devm_clk_get

Fix a static code checker warning:
drivers/spi/spi-bcm2835aux.c:460
 bcm2835aux_spi_probe() warn: passing zero to 'PTR_ERR'

In case of error, the function devm_clk_get() returns ERR_PTR()
and not returns NULL.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---

diff --git a/drivers/spi/spi-bcm2835aux.c b/drivers/spi/spi-bcm2835aux.c
index 671e374e1b01f..f7e054848ca5f 100644
--- a/drivers/spi/spi-bcm2835aux.c
+++ b/drivers/spi/spi-bcm2835aux.c
@@ -456,7 +456,7 @@ static int bcm2835aux_spi_probe(struct platform_device *pdev)
 	}
 
 	bs->clk = devm_clk_get(&pdev->dev, NULL);
-	if ((!bs->clk) || (IS_ERR(bs->clk))) {
+	if (IS_ERR(bs->clk)) {
 		err = PTR_ERR(bs->clk);
 		dev_err(&pdev->dev, "could not get clk: %d\n", err);
 		goto out_master_put;