From: Youwan Wang Date: Mon, 24 Jun 2024 02:31:01 +0000 (+0800) Subject: ACPI / amba: Drop unnecessary check for registered amba_dummy_clk X-Git-Tag: v6.11-rc1~217^2~1^7~1 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=bfe3f0df3e3c0afdbe147d2479fe9aee4d0683e9;p=thirdparty%2Fkernel%2Flinux.git ACPI / amba: Drop unnecessary check for registered amba_dummy_clk amba_register_dummy_clk() is called only once from acpi_amba_init() and acpi_amba_init() itself is called once during the initialisation. amba_dummy_clk can't be initialised before this in any other code path and hence the check for already registered amba_dummy_clk is not necessary. Drop the same. Signed-off-by: Youwan Wang Acked-by: Sudeep Holla Acked-by: Hanjun Guo Link: https://lore.kernel.org/r/20240624023101.369633-1-youwan@nfschina.com Signed-off-by: Catalin Marinas --- diff --git a/drivers/acpi/arm64/amba.c b/drivers/acpi/arm64/amba.c index e1f0bbb8f3938..1350083bce5f1 100644 --- a/drivers/acpi/arm64/amba.c +++ b/drivers/acpi/arm64/amba.c @@ -27,11 +27,7 @@ static const struct acpi_device_id amba_id_list[] = { static void amba_register_dummy_clk(void) { - static struct clk *amba_dummy_clk; - - /* If clock already registered */ - if (amba_dummy_clk) - return; + struct clk *amba_dummy_clk; amba_dummy_clk = clk_register_fixed_rate(NULL, "apb_pclk", NULL, 0, 0); clk_register_clkdev(amba_dummy_clk, "apb_pclk", NULL);