From: Chris Laplante Date: Tue, 16 Sep 2025 15:51:43 +0000 (-0400) Subject: devtool: __init__: small cleanups X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=bff3a3d9f8fa695fa05d91419d995de4c8009d9b;p=thirdparty%2Fopenembedded%2Fopenembedded-core-contrib.git devtool: __init__: small cleanups + Remove unused exec_fakeroot method, which wouldn't work anyway since it doesn't pass kwargs correctly. + Fix a None comparison Signed-off-by: Chris Laplante Signed-off-by: Mathieu Dubois-Briand Signed-off-by: Richard Purdie --- diff --git a/scripts/lib/devtool/__init__.py b/scripts/lib/devtool/__init__.py index 396e8025b7..717a60c039 100644 --- a/scripts/lib/devtool/__init__.py +++ b/scripts/lib/devtool/__init__.py @@ -66,7 +66,7 @@ def exec_watch(cmd, **options): sys.stdout.write(out) sys.stdout.flush() buf += out - elif out == '' and process.poll() != None: + elif out == '' and process.poll() is not None: break if process.returncode != 0: @@ -74,13 +74,6 @@ def exec_watch(cmd, **options): return buf, None -def exec_fakeroot(d, cmd, **kwargs): - """Run a command under fakeroot (pseudo, in fact) so that it picks up the appropriate file permissions""" - # Grab the command and check it actually exists - fakerootcmd = d.getVar('FAKEROOTCMD') - fakerootenv = d.getVar('FAKEROOTENV') - exec_fakeroot_no_d(fakerootcmd, fakerootenv, cmd, kwargs) - def exec_fakeroot_no_d(fakerootcmd, fakerootenv, cmd, **kwargs): if not os.path.exists(fakerootcmd): logger.error('pseudo executable %s could not be found - have you run a build yet? pseudo-native should install this and if you have run any build then that should have been built')