From: kernel test robot <lkp@intel.com>
Date: Tue, 3 Aug 2021 14:59:55 +0000 (+0200)
Subject: powerpc/kexec: fix for_each_child.cocci warning
X-Git-Tag: v5.15-rc1~100^2~123
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c00103abf76fd3916596afd07dd3fdeee0dca15d;p=thirdparty%2Fkernel%2Flinux.git

powerpc/kexec: fix for_each_child.cocci warning

for_each_node_by_type should have of_node_put() before return.

Generated by: scripts/coccinelle/iterators/for_each_child.cocci

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/alpine.DEB.2.22.394.2108031654080.17639@hadrien
---

diff --git a/arch/powerpc/kexec/core_64.c b/arch/powerpc/kexec/core_64.c
index 84618d3c8013b..89c069d664a5d 100644
--- a/arch/powerpc/kexec/core_64.c
+++ b/arch/powerpc/kexec/core_64.c
@@ -64,8 +64,10 @@ int default_machine_kexec_prepare(struct kimage *image)
 			begin = image->segment[i].mem;
 			end = begin + image->segment[i].memsz;
 
-			if ((begin < high) && (end > low))
+			if ((begin < high) && (end > low)) {
+				of_node_put(node);
 				return -ETXTBSY;
+			}
 		}
 	}