From: Kent Overstreet <kent.overstreet@linux.dev>
Date: Sun, 13 Jul 2025 21:19:34 +0000 (-0400)
Subject: bcachefs: Fix reference to invalid bucket in copygc
X-Git-Tag: v6.16-rc7~36^2~2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c02b943f7d127caf43f49ab6c9eaf8e1b082b9af;p=thirdparty%2Flinux.git

bcachefs: Fix reference to invalid bucket in copygc

Use bch2_dev_bucket_tryget() instead of bch2_dev_tryget() before
checking the bucket bitmap.

Reported-by: syzbot+3168625f36f4a539237e@syzkaller.appspotmail.com
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
---

diff --git a/fs/bcachefs/movinggc.c b/fs/bcachefs/movinggc.c
index 27e68d470ad09..5e6de91a87630 100644
--- a/fs/bcachefs/movinggc.c
+++ b/fs/bcachefs/movinggc.c
@@ -71,7 +71,7 @@ static int bch2_bucket_is_movable(struct btree_trans *trans,
 	if (ret)
 		return ret;
 
-	struct bch_dev *ca = bch2_dev_tryget(c, k.k->p.inode);
+	struct bch_dev *ca = bch2_dev_bucket_tryget(c, k.k->p);
 	if (!ca)
 		goto out;