From: Xiubo Li Date: Wed, 4 Sep 2024 22:22:18 +0000 (+0800) Subject: ceph: remove the incorrect Fw reference check when dirtying pages X-Git-Tag: v6.12-rc1~16^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c08dfb1b49492c09cf13838c71897493ea3b424e;p=thirdparty%2Flinux.git ceph: remove the incorrect Fw reference check when dirtying pages When doing the direct-io reads it will also try to mark pages dirty, but for the read path it won't hold the Fw caps and there is case will it get the Fw reference. Fixes: 5dda377cf0a6 ("ceph: set i_head_snapc when getting CEPH_CAP_FILE_WR reference") Signed-off-by: Xiubo Li Reviewed-by: Patrick Donnelly Signed-off-by: Ilya Dryomov --- diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c index c4744a02db753..0df4623785ddb 100644 --- a/fs/ceph/addr.c +++ b/fs/ceph/addr.c @@ -95,7 +95,6 @@ static bool ceph_dirty_folio(struct address_space *mapping, struct folio *folio) /* dirty the head */ spin_lock(&ci->i_ceph_lock); - BUG_ON(ci->i_wr_ref == 0); // caller should hold Fw reference if (__ceph_have_pending_cap_snap(ci)) { struct ceph_cap_snap *capsnap = list_last_entry(&ci->i_cap_snaps,