From: Darrick J. Wong <djwong@kernel.org>
Date: Thu, 16 Jan 2025 21:22:03 +0000 (-0800)
Subject: xfs_repair: don't obliterate return codes
X-Git-Tag: v6.13.0~14
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c08fe89d4441bb95aaf6f6c1751a9537ee00173b;p=thirdparty%2Fxfsprogs-dev.git

xfs_repair: don't obliterate return codes

Don't clobber error here, it's err2 that's the temporary variable.

Coverity-id: 1637363
Fixes: b790ab2a303d58 ("xfs_repair: support quota inodes in the metadata directory")
Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---

diff --git a/repair/quotacheck.c b/repair/quotacheck.c
index 8c7339b2..7953144c 100644
--- a/repair/quotacheck.c
+++ b/repair/quotacheck.c
@@ -691,7 +691,7 @@ discover_quota_inodes(
 	err2 = mark_quota_inode(tp, dp, XFS_DQTYPE_GROUP);
 	if (err2 && !error)
 		error = err2;
-	error = mark_quota_inode(tp, dp, XFS_DQTYPE_PROJ);
+	err2 = mark_quota_inode(tp, dp, XFS_DQTYPE_PROJ);
 	if (err2 && !error)
 		error = err2;