From: Simon Marchi <simon.marchi@efficios.com>
Date: Mon, 25 Aug 2025 15:44:22 +0000 (-0400)
Subject: gdb/testsuite: use gdb_test_no_output when dumping in gdb.base/dump.exp
X-Git-Tag: gdb-17-branchpoint~140
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c09325a5a67c613ba97057f7132e98fd99508666;p=thirdparty%2Fbinutils-gdb.git

gdb/testsuite: use gdb_test_no_output when dumping in gdb.base/dump.exp

I don't know if this is true on all platforms, but from what I can see
on Linux, the dump commands don't output anything.  Use
gdb_test_no_output, which should be a bit more robust than checking for
some specific error patterns.

Change-Id: Idc82298c4752ba7808659dfea2f8324c8a97052d
Approved-By: Tom Tromey <tom@tromey.com>
---

diff --git a/gdb/testsuite/gdb.base/dump.exp b/gdb/testsuite/gdb.base/dump.exp
index a55e5b060db..7c84056dfa6 100644
--- a/gdb/testsuite/gdb.base/dump.exp
+++ b/gdb/testsuite/gdb.base/dump.exp
@@ -107,14 +107,7 @@ set endian [get_endianness]
 # Now generate some dump files.
 
 proc make_dump_file { command msg } {
-  global gdb_prompt
-
-    gdb_test_multiple "${command}" "$msg" {
-	-re ".*\[Ee\]rror.*$gdb_prompt $"      { fail $msg }
-	-re ".*\[Ww\]arning.*$gdb_prompt $"    { fail $msg }
-	-re ".*\[Uu\]ndefined .*$gdb_prompt $" { fail $msg }
-	-re ".*$gdb_prompt $"                  { pass $msg }
-    }
+    gdb_test_no_output "${command}" "$msg"
 }
 
 make_dump_file "dump val [set intarr1.bin] intarray" \