From: ndossche <niels.dossche@ugent.be>
Date: Tue, 7 Mar 2023 12:27:15 +0000 (+0100)
Subject: Add missing assignment to EVP_get_digestbynid()
X-Git-Tag: openssl-3.2.0-alpha1~1173
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c09c202e9bc66f0300ee598ca94f2b3fa5a5899d;p=thirdparty%2Fopenssl.git

Add missing assignment to EVP_get_digestbynid()

The assignment of the result of EVP_get_digestbynid() did not happen
which made the fallback not actually perform the fallback.

CLA: trivial

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/20447)
---

diff --git a/crypto/evp/evp_pbe.c b/crypto/evp/evp_pbe.c
index 5208f7cef84..d943dfeaddf 100644
--- a/crypto/evp/evp_pbe.c
+++ b/crypto/evp/evp_pbe.c
@@ -143,7 +143,7 @@ int EVP_PBE_CipherInit_ex(ASN1_OBJECT *pbe_obj, const char *pass, int passlen,
         md = md_fetch = EVP_MD_fetch(libctx, OBJ_nid2sn(md_nid), propq);
         /* Fallback to legacy method */
         if (md == NULL)
-            EVP_get_digestbynid(md_nid);
+            md = EVP_get_digestbynid(md_nid);
 
         if (md == NULL) {
             (void)ERR_clear_last_mark();