From: Colin Ian King <colin.king@canonical.com>
Date: Tue, 17 Oct 2017 15:54:52 +0000 (+0100)
Subject: ipmi_si: fix memory leak on new_smi
X-Git-Tag: v4.15-rc1~94^2~2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c0a32fe13cd323ca9420500b16fd69589c9ba91e;p=thirdparty%2Fkernel%2Flinux.git

ipmi_si: fix memory leak on new_smi

The error exit path omits kfree'ing the allocated new_smi, causing a memory
leak.  Fix this by kfree'ing new_smi.

Detected by CoverityScan, CID#14582571 ("Resource Leak")

Fixes: 7e030d6dff71 ("ipmi: Prefer ACPI system interfaces over SMBIOS ones")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
---

diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
index 55e0c42bee4d5..4c16af64f73a1 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -2004,6 +2004,7 @@ int ipmi_si_add_smi(struct si_sm_io *io)
 				 ipmi_addr_src_to_str(new_smi->io.addr_source),
 				 si_to_str[new_smi->io.si_type]);
 			rv = -EBUSY;
+			kfree(new_smi);
 			goto out_err;
 		}
 	}