From: Aaron Lu Date: Thu, 8 May 2025 08:30:36 +0000 (+0800) Subject: block: remove test of incorrect io priority level X-Git-Tag: v6.15-rc6~20^2~1 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c0d0a9ff6d5b5b23ddabde8bcbafb28fa454ae00;p=thirdparty%2Fkernel%2Flinux.git block: remove test of incorrect io priority level Ever since commit eca2040972b4("scsi: block: ioprio: Clean up interface definition"), the macro IOPRIO_PRIO_LEVEL() will mask the level value to something between 0 and 7 so necessarily, level will always be lower than IOPRIO_NR_LEVELS(8). Remove this obsolete check. Reported-by: Kexin Wei Cc: Damien Le Moal Signed-off-by: Aaron Lu Reviewed-by: Damien Le Moal Link: https://lore.kernel.org/r/20250508083018.GA769554@bytedance Signed-off-by: Jens Axboe --- diff --git a/block/ioprio.c b/block/ioprio.c index 73301a261429f..f0ee2798539c0 100644 --- a/block/ioprio.c +++ b/block/ioprio.c @@ -46,12 +46,8 @@ int ioprio_check_cap(int ioprio) */ if (!capable(CAP_SYS_ADMIN) && !capable(CAP_SYS_NICE)) return -EPERM; - fallthrough; - /* rt has prio field too */ - case IOPRIO_CLASS_BE: - if (level >= IOPRIO_NR_LEVELS) - return -EINVAL; break; + case IOPRIO_CLASS_BE: case IOPRIO_CLASS_IDLE: break; case IOPRIO_CLASS_NONE: