From: Frédéric Lécaille <flecaille@haproxy.com>
Date: Wed, 10 Mar 2021 10:51:38 +0000 (+0100)
Subject: BUG/MINOR: connection: Missing QUIC initialization
X-Git-Tag: v2.4-dev12~55
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c0ed91910a43020485c89662c0df1cf5fcd3d93a;p=thirdparty%2Fhaproxy.git

BUG/MINOR: connection: Missing QUIC initialization

The QUIC connection struct connection member was not initialized. This may
make randomly haproxy handle TLS connections as QUIC ones only when QUIC support
is enabled leading to such OpenSSL errors (captured from a reg test output, TLS
Client-Hello callback failed):

    OpenSSL error[0x10000085] OPENSSL_internal: CONNECTION_REJECTED
    OpenSSL error[0x10000410] OPENSSL_internal: SSLV3_ALERT_HANDSHAKE_FAILURE
    OpenSSL error[0x1000009a] OPENSSL_internal: HANDSHAKE_FAILURE_ON_CLIENT_HELLO

This patch should fix #1168 github issue.
---

diff --git a/include/haproxy/connection.h b/include/haproxy/connection.h
index 46a521e01c..739d6a636e 100644
--- a/include/haproxy/connection.h
+++ b/include/haproxy/connection.h
@@ -357,6 +357,7 @@ static inline void conn_init(struct connection *conn, void *target)
 	conn->dst = NULL;
 	conn->proxy_authority = IST_NULL;
 	conn->proxy_unique_id = IST_NULL;
+	conn->qc = NULL;
 	conn->hash_node = NULL;
 }