From: Miquel Sabaté Solà Date: Tue, 17 Sep 2024 13:42:46 +0000 (+0200) Subject: cpufreq: Avoid a bad reference count on CPU node X-Git-Tag: v6.12-rc2~19^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c0f02536fffbbec71aced36d52a765f8c4493dc2;p=thirdparty%2Flinux.git cpufreq: Avoid a bad reference count on CPU node In the parse_perf_domain function, if the call to of_parse_phandle_with_args returns an error, then the reference to the CPU device node that was acquired at the start of the function would not be properly decremented. Address this by declaring the variable with the __free(device_node) cleanup attribute. Signed-off-by: Miquel Sabaté Solà Acked-by: Viresh Kumar Link: https://patch.msgid.link/20240917134246.584026-1-mikisabate@gmail.com Cc: All applicable Signed-off-by: Rafael J. Wysocki --- diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h index e0e19d9c13231..7fe0981a7e467 100644 --- a/include/linux/cpufreq.h +++ b/include/linux/cpufreq.h @@ -1107,10 +1107,9 @@ static inline int parse_perf_domain(int cpu, const char *list_name, const char *cell_name, struct of_phandle_args *args) { - struct device_node *cpu_np; int ret; - cpu_np = of_cpu_device_node_get(cpu); + struct device_node *cpu_np __free(device_node) = of_cpu_device_node_get(cpu); if (!cpu_np) return -ENODEV; @@ -1118,9 +1117,6 @@ static inline int parse_perf_domain(int cpu, const char *list_name, args); if (ret < 0) return ret; - - of_node_put(cpu_np); - return 0; }