From: Zhang Changzhong Date: Thu, 28 Oct 2021 14:38:25 +0000 (+0800) Subject: can: j1939: j1939_tp_cmd_recv(): ignore abort message in the BAM transport X-Git-Tag: v5.16-rc1~50^2~33^2~7 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c0f49d98006f2db3333b917caac65bce2af9865c;p=thirdparty%2Fkernel%2Flinux.git can: j1939: j1939_tp_cmd_recv(): ignore abort message in the BAM transport This patch prevents BAM transport from being closed by receiving abort message, as specified in SAE-J1939-82 2015 (A.3.3 Row 4). Fixes: 9d71dd0c7009 ("can: add support of SAE J1939 protocol") Link: https://lore.kernel.org/all/1635431907-15617-2-git-send-email-zhangchangzhong@huawei.com Cc: stable@vger.kernel.org Signed-off-by: Zhang Changzhong Acked-by: Oleksij Rempel Signed-off-by: Marc Kleine-Budde --- diff --git a/net/can/j1939/transport.c b/net/can/j1939/transport.c index 6c0a0ebdd024c..05eb3d059e175 100644 --- a/net/can/j1939/transport.c +++ b/net/can/j1939/transport.c @@ -2085,6 +2085,12 @@ static void j1939_tp_cmd_recv(struct j1939_priv *priv, struct sk_buff *skb) break; case J1939_ETP_CMD_ABORT: /* && J1939_TP_CMD_ABORT */ + if (j1939_cb_is_broadcast(skcb)) { + netdev_err_once(priv->ndev, "%s: abort to broadcast (%02x), ignoring!\n", + __func__, skcb->addr.sa); + return; + } + if (j1939_tp_im_transmitter(skcb)) j1939_xtp_rx_abort(priv, skb, true);