From: Petr Špaček <petr.spacek@nic.cz>
Date: Tue, 3 Dec 2019 14:09:47 +0000 (+0100)
Subject: iterate: clarify error messages about CNAME chains
X-Git-Tag: v4.3.0~2^2~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c0fcb467c56b98ab003685cb1c0d93463ab78f40;p=thirdparty%2Fknot-resolver.git

iterate: clarify error messages about CNAME chains
---

diff --git a/lib/layer/iterate.c b/lib/layer/iterate.c
index 9a78b23df..ebd3604b8 100644
--- a/lib/layer/iterate.c
+++ b/lib/layer/iterate.c
@@ -574,13 +574,14 @@ static int unroll_cname(knot_pkt_t *pkt, struct kr_request *req, bool referral,
 			break;
 		}
 		if (++(query->cname_depth) > KR_CNAME_CHAIN_LIMIT) {
-			VERBOSE_MSG("<= cname chain longer than %d\n",
-					(int)KR_CNAME_CHAIN_LIMIT);
+			VERBOSE_MSG("<= error: CNAME chain exceeded max length %d\n",
+					/* people count objects from 0, no CNAME = 0 */
+					(int)KR_CNAME_CHAIN_LIMIT - 1);
 			return KR_STATE_FAIL;
 		}
 
 		if (knot_dname_is_equal(cname, pending_cname)) {
-			VERBOSE_MSG("<= cname chain loop\n");
+			VERBOSE_MSG("<= error: CNAME chain loop detected\n");
 			return KR_STATE_FAIL;
 		}
 		/* In strict mode, explicitly fetch each CNAME target. */