From: Markus Armbruster <armbru@redhat.com>
Date: Tue, 25 Nov 2025 07:05:54 +0000 (+0100)
Subject: migration: Fix double-free on error path
X-Git-Tag: v10.2.0-rc2~1^2~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c1116b1d73fa0cd4346484688ebb22ecd847ec3f;p=thirdparty%2Fqemu.git

migration: Fix double-free on error path

Fixes: ffaa1b50a879 (migration: Use warn_reportf_err() where appropriate)
Resolves: Coverity CID 1643463
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20251125070554.2256181-1-armbru@redhat.com>
Acked-by: Peter Xu <peterx@redhat.com>
---

diff --git a/migration/multifd.c b/migration/multifd.c
index 6210454838..3203dc98e1 100644
--- a/migration/multifd.c
+++ b/migration/multifd.c
@@ -450,7 +450,7 @@ static void multifd_send_set_error(Error *err)
  */
 static void migration_ioc_shutdown_gracefully(QIOChannel *ioc)
 {
-    g_autoptr(Error) local_err = NULL;
+    Error *local_err = NULL;
 
     if (!migration_has_failed(migrate_get_current()) &&
         object_dynamic_cast((Object *)ioc, TYPE_QIO_CHANNEL_TLS)) {