From: Stephan Bosch <stephan.bosch@dovecot.fi>
Date: Mon, 11 Dec 2017 09:41:53 +0000 (+0100)
Subject: lib-smtp: server: Remove useless o_stream_flush() in smtp_server_connection_disconnect().
X-Git-Tag: 2.3.0.rc1~154
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c13d3128fdf314fc8b550c9cf03fe673b33ce32f;p=thirdparty%2Fdovecot%2Fcore.git

lib-smtp: server: Remove useless o_stream_flush() in smtp_server_connection_disconnect().

This is already performed implicitly by o_stream_uncork().
Fixes a problem found by Coverity.
---

diff --git a/src/lib-smtp/smtp-server-connection.c b/src/lib-smtp/smtp-server-connection.c
index 145df3e6b4..f9355258f7 100644
--- a/src/lib-smtp/smtp-server-connection.c
+++ b/src/lib-smtp/smtp-server-connection.c
@@ -1014,10 +1014,8 @@ smtp_server_connection_disconnect(struct smtp_server_connection *conn,
 	smtp_server_connection_update_stats(conn);
 
 	smtp_server_connection_timeout_stop(conn);
-	if (conn->conn.output != NULL) {
-		o_stream_flush(conn->conn.output);
+	if (conn->conn.output != NULL)
 		o_stream_uncork(conn->conn.output);
-	}
 	if (conn->smtp_parser != NULL)
 		smtp_command_parser_deinit(&conn->smtp_parser);
 	if (conn->ssl_iostream != NULL)