From: Roland McGrath <roland@redhat.com>
Date: Wed, 23 Jun 2010 00:08:43 +0000 (-0700)
Subject: Fix check_constant_offset braino.
X-Git-Tag: elfutils-0.148~3
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c16966a0043dc173fcaab5d3f8b754b4e9c9ceb7;p=thirdparty%2Felfutils.git

Fix check_constant_offset braino.
---

diff --git a/libdw/ChangeLog b/libdw/ChangeLog
index 5d274cb55..17658581d 100644
--- a/libdw/ChangeLog
+++ b/libdw/ChangeLog
@@ -1,5 +1,7 @@
 2010-06-22  Roland McGrath  <roland@redhat.com>
 
+	* dwarf_getlocation.c (check_constant_offset): data[48] are constant.
+
 	* dwarf_getsrclines.c: Fix signed comparison warning in extended
 	opcode parsing.
 
diff --git a/libdw/dwarf_getlocation.c b/libdw/dwarf_getlocation.c
index 56091cd9c..e960ef9e9 100644
--- a/libdw/dwarf_getlocation.c
+++ b/libdw/dwarf_getlocation.c
@@ -165,16 +165,11 @@ check_constant_offset (Dwarf_Attribute *attr,
 
     case DW_FORM_data1:
     case DW_FORM_data2:
+    case DW_FORM_data4:
+    case DW_FORM_data8:
     case DW_FORM_sdata:
     case DW_FORM_udata:
       break;
-
-    case DW_FORM_data4:
-    case DW_FORM_data8:
-      /* These are loclistptr, not constants.
-	 XXX check cu->version > 3???
-      */
-      return 1;
     }
 
   /* Check whether we already cached this location.  */