From: Dan Carpenter Date: Wed, 30 Sep 2020 12:30:36 +0000 (+0300) Subject: staging: vchiq: Fix an uninitialized variable X-Git-Tag: v5.10-rc1~126^2~41 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=c1981671a4d8ec60ef3ef245f3fdba75929817aa;p=thirdparty%2Fkernel%2Flinux.git staging: vchiq: Fix an uninitialized variable Smatch complains that "userdata" can be passed to vchiq_bulk_transfer() without being initialized. This leads to a potential information leak later on. Fixes: a4367cd2b231 ("staging: vchiq: convert compat bulk transfer") Signed-off-by: Dan Carpenter Acked-by: Arnd Bergmann Link: https://lore.kernel.org/r/20200930123036.GC4282@kadam Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index 590415561b73a..71b962777da5f 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c @@ -952,7 +952,7 @@ static int vchiq_irq_queue_bulk_tx_rx(struct vchiq_instance *instance, { struct vchiq_service *service; struct bulk_waiter_node *waiter = NULL; - void *userdata; + void *userdata = NULL; int status = 0; int ret;